Merged
Conversation
Member
|
How does this PR relate to #73? |
Contributor
Author
Contributor
Author
|
I don't see the benefit of keeping compatibility in this case. |
Member
|
I'm not saying we should not keep compatibility, I'm saying that we should consider that we are keeping it: a change in case should IMO be considered compatible. |
SenseException
approved these changes
Aug 16, 2023
Member
SenseException
left a comment
There was a problem hiding this comment.
a change in case should IMO be considered compatible.
I haven't worked with a SQL dialect yet that was case sensitive.
Member
|
Thanks @rinu ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see any benefit to anyone ever having lowercase keywords.
Not all reserved words are detected correctly in this project. A simple regex is simple but it lacks context. But so what, if it's a field name, put ticks around it.
Closes #73