Skip to content

Update tokenizer to understand that WITH from "WITH TIMEZONE" does not require a new line#156

Open
allan-simon wants to merge 4 commits intodoctrine:1.5.xfrom
allan-simon:patch-1
Open

Update tokenizer to understand that WITH from "WITH TIMEZONE" does not require a new line#156
allan-simon wants to merge 4 commits intodoctrine:1.5.xfrom
allan-simon:patch-1

Conversation

@allan-simon
Copy link

otherwise it creates broken output like

            CREATE TABLE whatever (
              id INT NOT NULL,
              last_modification_datetime TIMESTAMP(0)
              WITH
                TIME ZONE NOT NULL,
                creation_datetime TIMESTAMP(0)
              WITH
                TIME ZONE NOT NULL,
                hashed_token VARCHAR(512) DEFAULT NULL,
                PRIMARY KEY(id)
            )

instead of

            CREATE TABLE whatever (
              id INT NOT NULL,
              last_modification_datetime TIMESTAMP(0)  WITH TIME ZONE NOT NULL,
              creation_datetime TIMESTAMP(0) WITH TIME ZONE NOT NULL,
              hashed_token VARCHAR(512) DEFAULT NULL,
              PRIMARY KEY(id)
            )

…t require a new line

otherwise it creates broken output like 


```sql
            CREATE TABLE whatever (
              id INT NOT NULL,
              last_modification_datetime TIMESTAMP(0)
              WITH
                TIME ZONE NOT NULL,
                creation_datetime TIMESTAMP(0)
              WITH
                TIME ZONE NOT NULL,
                hashed_token VARCHAR(512) DEFAULT NULL,
                PRIMARY KEY(id)
            )
```

instead of 

```sql
            CREATE TABLE whatever (
              id INT NOT NULL,
              last_modification_datetime TIMESTAMP(0)  WITH TIME ZONE NOT NULL,
              creation_datetime TIMESTAMP(0) WITH TIME ZONE NOT NULL,
                hashed_token VARCHAR(512) DEFAULT NULL,
                PRIMARY KEY(id)
            )
```
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved to early. The failing workflows need to be adressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants