Update tokenizer to understand that WITH from "WITH TIMEZONE" does not require a new line#156
Open
allan-simon wants to merge 4 commits intodoctrine:1.5.xfrom
Open
Update tokenizer to understand that WITH from "WITH TIMEZONE" does not require a new line#156allan-simon wants to merge 4 commits intodoctrine:1.5.xfrom
allan-simon wants to merge 4 commits intodoctrine:1.5.xfrom
Conversation
…t require a new line
otherwise it creates broken output like
```sql
CREATE TABLE whatever (
id INT NOT NULL,
last_modification_datetime TIMESTAMP(0)
WITH
TIME ZONE NOT NULL,
creation_datetime TIMESTAMP(0)
WITH
TIME ZONE NOT NULL,
hashed_token VARCHAR(512) DEFAULT NULL,
PRIMARY KEY(id)
)
```
instead of
```sql
CREATE TABLE whatever (
id INT NOT NULL,
last_modification_datetime TIMESTAMP(0) WITH TIME ZONE NOT NULL,
creation_datetime TIMESTAMP(0) WITH TIME ZONE NOT NULL,
hashed_token VARCHAR(512) DEFAULT NULL,
PRIMARY KEY(id)
)
```
SenseException
approved these changes
Sep 10, 2025
SenseException
requested changes
Sep 10, 2025
Member
SenseException
left a comment
There was a problem hiding this comment.
I approved to early. The failing workflows need to be adressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise it creates broken output like
instead of