Conversation
On macOS the credentials cannot be stored if one already exists. But we didn't want to clobber the credentials on Save. A new `Upsert` function is added to clobber credentials purposefully. macOS is the only operating system that requires this to be atomic, but others might require it too. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
joe0BAB
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the credentials cannot be stored if one already exists. But we didn't want to clobber the credentials on Save.
A new
Upsertfunction is added to clobber credentials purposefully. macOS is the only operating system that requires this to be atomic, but others might require it too.