Conversation
Signed-off-by: Johannes Großmann <grossmann.johannes@t-online.de>
kiview
approved these changes
Feb 27, 2026
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR cleanly bumps the internal x module dependency from v0.0.22-do.not.use to v0.0.23-do.not.use across all modules. The changes are consistent and properly update:
- All go.mod files referencing the
xmodule - The go.sum file in plugins/credentialhelper (the only one that needs updating)
- The vendor/modules.txt file
All modules use replace directives pointing to local directories (../x or ./x), which means go.sum entries for the x module are not required in the other modules. The PR looks good!
There was a problem hiding this comment.
✅ Review Complete
This dependency version bump looks good! All occurrences of github.com/docker/secrets-engine/x have been consistently updated from v0.0.22-do.not.use to v0.0.23-do.not.use across all affected files:
- ✓ All 6 go.mod files updated consistently
- ✓ go.sum updated with correct hash
- ✓ vendor/modules.txt updated accordingly
No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.