More doc fixing with "agent serve mcp"#2130
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 16, 2026
Merged
Conversation
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
Summary
This PR correctly fixes command-line syntax in documentation examples:
- docs/features/acp/index.md: Fixed the JavaScript
spawn()call to properly pass arguments as an array in the second parameter - docs/features/mcp-mode/index.md: Added the missing
"serve"argument to the MCP configuration args array
Both corrections align with the documented command syntax (docker agent serve acp and docker agent serve mcp). The changes are accurate and improve the documentation quality.
Findings
No bugs detected. The documentation fixes are correct.
dgageot
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.