Skip to content

Fix a few characters for tmux #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 1 commit into from
Mar 16, 2026
Merged

Fix a few characters for tmux #2128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/tui/components/scrollbar/scrollbar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ type Model struct {
func New() *Model {
return &Model{
width: Width,
trackChar: "│",
thumbChar: "│",
trackChar: "⎪",
Copy link

@docker-agent docker-agent bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ MEDIUM: Terminal Compatibility Concern

The new Unicode characters may have compatibility issues across different terminal environments:

  • Track character ⎪ (U+23AA): This is from the Mathematical Operators block (intended for extending vertical box drawing) rather than the standard Box Drawing block. Some terminals or fonts may:

    • Render it with incorrect width
    • Display it as a missing glyph
    • Calculate character width differently (especially in tmux)

  • Previous character │ (U+2502): Part of the standard Box Drawing set with better cross-terminal support

Context: While this change intentionally fixes tmux rendering (per the PR title), it may introduce compatibility issues in other terminal emulators or font configurations. This is a classic engineering tradeoff: fixing a known issue (tmux) while potentially creating unknown issues (other terminals).

Recommendation: Consider testing this change across multiple terminal emulators (iTerm2, Terminal.app, Windows Terminal, Alacritty, etc.) to ensure the new characters render correctly in common environments.

thumbChar: "┃",
}
}

Expand Down
Loading