Fix issues on builtin filesystem tools#2125
Merged
dgageot merged 7 commits intodocker:mainfrom Mar 16, 2026
Merged
Conversation
Assisted-By: docker-agent
…ipleFiles Assisted-By: docker-agent
os.IsNotExist does not unwrap errors. errors.Is handles wrapped errors correctly. Assisted-By: docker-agent
Assisted-By: docker-agent
The caller (handleReadFile) already confirmed the file exists via os.Stat, so the os.ErrNotExist branch inside readImageFile can never trigger. Assisted-By: docker-agent
Avoids allocating a new closure on every handleDirectoryTree call. Assisted-By: docker-agent
- Make allowAllPaths a function instead of a var to prevent reassignment - Avoid duplicate err.Error() call in readImageFile Assisted-By: docker-agent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR contains clean refactoring improvements to the filesystem tool code with no bugs detected.
Changes Reviewed
The PR makes several idiomatic Go improvements:
- Modernized error checking: Replaced deprecated
os.IsNotExist()with the modernerrors.Is(err, fs.ErrNotExist)pattern - Reduced code duplication: Extracted repeated
string(content)conversions to atextvariable - Improved code organization: Replaced an inline closure with a top-level
allowAllPathshelper function - Simplified logic: Streamlined the boolean return in
shouldIgnorePath()
All changes follow Go best practices and maintain the existing functionality without introducing any logic errors.
Findings
No issues found. ✅
gtardif
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.