Simplify MCP catalog loading: single fetch per run with ETag caching#2124
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 16, 2026
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Replace the complex multi-layered catalog caching (RWMutex, background refresh goroutine, stale-while-revalidate, double-checked locking) with a straightforward single-fetch design: - Fetch the catalog at most once per process via sync.OnceValues, using context.Background() so that a short-lived caller context cannot permanently poison the cached result. - Use HTTP ETag / If-None-Match for conditional requests (304 fast path). - Fall back to the disk cache on any network failure. - Write the disk cache atomically (temp file + rename) so that a crash mid-write cannot leave a corrupt file for the next run. - Add a 15 s context timeout on the HTTP request, replacing the unbounded http.Get. - Use paths.GetCacheDir() instead of a hand-rolled ~/.cagent path. - Fetch the JSON variant of the catalog URL (≈3× faster to parse) once at init time instead of rebuilding the string on every call. Assisted-By: docker-agent
dgageot
force-pushed
the
board/look-at-the-mcp-gateway-code-and-find-pl-0251e8c8
branch
from
c517fb9 to
d6db654
Compare
gtardif
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the complex multi-layered catalog caching (RWMutex, background refresh goroutine, stale-while-revalidate, double-checked locking) with a straightforward single-fetch design:
Assisted-By: docker-agent