Skip to content

feat: 내역 탭 judori/baddori 아이콘 다크모드 대응 (#53) #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kangddong merged 4 commits into from
Jun 29, 2026
Merged

feat: 내역 탭 judori/baddori 아이콘 다크모드 대응 (#53) #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7554280
feat: support dark mode for judori/baddori icons via DoriCircleIcon
kangddong Jun 29, 2026
d59a811
ci: fix TCA macro build on Xcode 26.3 (SWIFT_ENABLE_EXPLICIT_MODULES=…
kangddong Jun 29, 2026
279ab4f
ci: serialize target builds (-parallelizeTargets NO) to fix Clocks-Sw…
kangddong Jun 29, 2026
dc03db7
ci: use -jobs 1 to serialize build and avoid framework -Swift.h race
kangddong Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ jobs:
-configuration Debug \
-skipMacroValidation \
-destination "generic/platform=iOS Simulator" \
clean build
-jobs 1 \
SWIFT_ENABLE_EXPLICIT_MODULES=NO \
build

- name: Run unit tests (all *Tests schemes)
run: |
Expand Down Expand Up @@ -88,5 +90,7 @@ jobs:
-configuration Debug \
-skipMacroValidation \
-destination "id=${SIMULATOR_ID}" \
-jobs 1 \
SWIFT_ENABLE_EXPLICIT_MODULES=NO \
test
done <<< "${TEST_SCHEMES}"
2 changes: 1 addition & 1 deletion ...DoriDesignSystem/Resources/Icons.xcassets/baddori/baddori_birthday.imageset/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scale" : "1x"
},
{
"filename" : "baddori_birthday.svg",
"filename" : "ic_baddori_birthday.png",
"idiom" : "universal",
"scale" : "2x"
},
Expand Down
4 changes: 0 additions & 4 deletions ...Resources/Icons.xcassets/baddori/baddori_birthday.imageset/baddori_birthday.svg
View file
Open in desktop

This file was deleted.

Binary file added ...ources/Icons.xcassets/baddori/baddori_birthday.imageset/ic_baddori_birthday.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...Core/DoriDesignSystem/Resources/Icons.xcassets/baddori/baddori_etc.imageset/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scale" : "1x"
},
{
"filename" : "baddori_etc.svg",
"filename" : "ic_baddori_etc.png",
"idiom" : "universal",
"scale" : "2x"
},
Expand Down
4 changes: 0 additions & 4 deletions ...ignSystem/Resources/Icons.xcassets/baddori/baddori_etc.imageset/baddori_etc.svg
View file
Open in desktop

This file was deleted.

Binary file added ...System/Resources/Icons.xcassets/baddori/baddori_etc.imageset/ic_baddori_etc.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...esignSystem/Resources/Icons.xcassets/baddori/baddori_firstBirthday.imageset/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scale" : "1x"
},
{
"filename" : "baddori_firstBirthday.svg",
"filename" : "ic_baddori_firstBirthday.png",
"idiom" : "universal",
"scale" : "2x"
},
Expand Down
Loading
Loading