Skip to content

Fix: prevent cyclic XSD imports by tracking loaded files #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
do- merged 1 commit into from
Jul 14, 2025
Merged

Fix: prevent cyclic XSD imports by tracking loaded files #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions __tests__/XMLSchemata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
const path = require('path')
const { XMLSchemata } = require('../')

test('cyclic import', async () => {
const xsdPath = path.join(__dirname, '..', '__data__', '30213','RequestEGRN_v026.xsd')

const schemata = await new Promise((resolve, reject) => {
XMLSchemata.fromFile(xsdPath)
.then(s => resolve(s))
.catch(e => reject(e))
})

expect(schemata).toBeDefined()
expect(schemata.size).toBeGreaterThan(0)
})
6 changes: 6 additions & 0 deletions lib/XMLSchemata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ const XMLSchemata = class extends Map {
new XMLSchemaXml (this)
new XMLSchemaBuiltIn (this)

this.loadedFiles = new Set()

this.addFile (fn)

}
Expand Down Expand Up @@ -159,6 +161,10 @@ const XMLSchemata = class extends Map {

addFile (fn, options = {}) {

if (this.loadedFiles.has (fn)) return

this.loadedFiles.add (fn)

options.dirname = path.dirname (fn)

const document = this.parser.process (fs.readFileSync (fn, 'utf-8'))
Expand Down