[WIP] Enable/Disable service notifications#29
Conversation
|
@takus Thank you very much for the submission. I will review ASAP. Could you please take a look at the Travis errors in the meantime, please. |
|
Sorry, I'm a newbie of ruby/sinatra. I'll fix it soon. |
|
@dmytro it seems that there are some pending tests. Should I fix it? |
|
@takus Hi, apologies for the confusion with the errors. Those were because of the changes in RSpec, I've fixed them already. As for the URL's of the endpoints: I think it would be better to 'hang' notification routes from host and services. Like: and I've put simple guideline related to this: for the consistency of next additions. Please look at the Let me know if it is not clear. |
|
Please also be aware, there are some directory layout changes: |
Hi, i'm a user of this awesome product, and use it for our production systems.
I'd like to enable/disable service notification, and I tried to implement new feature in this PR.
After merging this, we can enable/disable monitor like this:
But I'm not sure whether this URI is proper or not. Could you tell me your thought? In addition, if I implement endpoint for other operation (e.g. enable/disable host notification), how should I implement it?
Of course, I'm ready for editing this PR.
Thanks in advance.