Conversation
Collaborator
|
Hey, thanks Nate! It seems that there were some issues in the CI, can you rebase/merge the current master branch to your srp-fix branch, such that we can retrigger the CI? Just now I (hopefully) fixed the CI in the master branch in previous merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources of information for the test samples (I'm a native speaker, books, online resources, ...)
Sources of information for the rules (I'm a native speaker, books, online resources, ...)
Currently it seems one letter is absent and another letter is incorrectly mapped, per these sources:
Note that the Wikipedia source also shows some disagreements with the sound mappings here, though they are less egregious and may vary dialectally (e.g. /o/ instead of /ɔ/).
I fixed the mappings to match these references. There doesn't seem to be any issues caused, and I don't think there will be since Serbian (
srp) does not have any post- or pre-processing data that I can see.No