Skip to content

possible error with srp-Cyrl#248

Open
n8rob wants to merge 1 commit into
masterfrom
srp-fix
Open

possible error with srp-Cyrl#248
n8rob wants to merge 1 commit into
masterfrom
srp-fix

Conversation

@n8rob
Copy link
Copy Markdown
Collaborator

@n8rob n8rob commented Apr 23, 2026

  • What kind of change does this PR introduce? Bug fix
  • Checklist
  • [] Have you added adequate tests on epitran/test?
  • [] Have you updated the language list in README.md?
  • [] Does it follow the - format?
  • [] Have you used IPA ɡ, not latin small letter g?
  • Sources of information for the test samples (I'm a native speaker, books, online resources, ...)

  • Sources of information for the rules (I'm a native speaker, books, online resources, ...)

  • What is the current behavior?

Currently it seems one letter is absent and another letter is incorrectly mapped, per these sources:

Note that the Wikipedia source also shows some disagreements with the sound mappings here, though they are less egregious and may vary dialectally (e.g. /o/ instead of /ɔ/).

  • What is the new behavior (if this is a feature change)?

I fixed the mappings to match these references. There doesn't seem to be any issues caused, and I don't think there will be since Serbian (srp) does not have any post- or pre-processing data that I can see.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

@n8rob n8rob requested a review from dmort27 April 23, 2026 18:25
@juice500ml
Copy link
Copy Markdown
Collaborator

Hey, thanks Nate! It seems that there were some issues in the CI, can you rebase/merge the current master branch to your srp-fix branch, such that we can retrigger the CI? Just now I (hopefully) fixed the CI in the master branch in previous merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants