New tests and phonetic rules for Russian#246
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? Fix issues with accuracy in Russian transcription
What is the current behavior? Russian transcription follows orthography too closely, resulting in incorrect IPA for words like легко, кого, встретить, etc.
What is the new behavior (if this is a feature change)? Rules for voicing assimilation, final consonant devoicing, and regular changes in pronunciation of <г> and <и> are accounted for, resulting in a more accurate pronunication. Vowel reduction has not been added as stress is out-of-scope.
Sources of information for the rules Own knowledge as an L2 speaker; textbooks Beginner's Russian and V Puti by Kudyma, Miller, and Kagan; Wikipedia (esp. Russian Phonology article)
Sources of information for the test samples Own knowledge plus Wiktionary for gold-standard IPA
Does this PR introduce a breaking change? No structural changes in the API, only rule updates.