Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ add_subdirectory(src/core)
add_subdirectory(src/storage)
add_subdirectory(src/memory)
add_subdirectory(src/query)
add_subdirectory(src/update)
add_subdirectory(src/main)

target_include_directories(core
Expand Down Expand Up @@ -517,4 +518,3 @@ set(CPACK_SOURCE_IGNORE_FILES
)

include(CPack)

2 changes: 1 addition & 1 deletion include/memory/array_ref.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ static_assert(sizeof(ArrayRef) == 16,
"ArrayRef must be 16 bytes (same as StringRef)");

// ArrayRef has custom copy/move/destructor for ref counting.
// It MUST NOT be trivially copyable using memcpy on it skips ref-count
// It MUST NOT be trivially copyable - using memcpy on it skips ref-count
// updates and causes use-after-free. Always use copy/move constructors.
static_assert(!std::is_trivially_copyable_v<ArrayRef>,
"ArrayRef must not be trivially copyable");
Expand Down
2 changes: 1 addition & 1 deletion include/memory/node_arena.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ class NodeArena {
const Value& value);

// =========================================================================
// apply_updates single public write entry point
// apply_updates - single public write entry point
// =========================================================================

/// Applies field updates; creates a new version when versioning is enabled.
Expand Down
2 changes: 1 addition & 1 deletion include/memory/string_ref.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ class StringRef {
};

// StringRef has custom copy/move/destructor for ref counting.
// It MUST NOT be trivially copyable using memcpy on it skips ref-count
// It MUST NOT be trivially copyable - using memcpy on it skips ref-count
// updates and causes use-after-free. Always use copy/move constructors.
static_assert(!std::is_trivially_copyable_v<StringRef>,
"StringRef must not be trivially copyable");
Expand Down
4 changes: 2 additions & 2 deletions src/common/types.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ std::string ValueRef::as_string() const {
}

// ---------------------------------------------------------------------------
// Value large methods moved from types.hpp
// Value - large methods moved from types.hpp
// ---------------------------------------------------------------------------

arrow::Status Value::append_element(Value element) {
Expand Down Expand Up @@ -168,7 +168,7 @@ Value Value::read_value_from_memory(const char* ptr, const ValueType type) {
}

// ---------------------------------------------------------------------------
// ValueRef large methods moved from types.hpp
// ValueRef - large methods moved from types.hpp
// ---------------------------------------------------------------------------

arrow::Result<std::shared_ptr<arrow::Scalar>> ValueRef::as_scalar() const {
Expand Down
Loading
Loading