Merged
Conversation
sebasgo
requested changes
Oct 17, 2025
Member
sebasgo
left a comment
There was a problem hiding this comment.
The new features need to be documented as well:
- please add an entry to
CHANGES.rstunder theVersion 0.4header stating we introduced new options to facilitate the use of Apptainer - please expand the Command Line Options section in
docs/usage.rst
Co-authored-by: Sebastian Gottfried <sebastian.gottfried@dlr.de>
Collaborator
Author
|
|
sebasgo
previously approved these changes
Nov 7, 2025
Co-authored-by: Sebastian Gottfried <sebastian.gottfried@dlr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this pull request is to enable pytest-isolate-mpi to work with Apptainer on an HPC system. For this two command line options were added:
--python-executable, which allows to set the path to a custom Python with which to run the spawned subsessions, the intention being that this will be the Python inside the container.--custom-ini-for-subsessionthat allows the subsession to use a different ini than the outer Pytest call. Some of the mpi args can cause problems when used inside an Apptainer container, so this is a very flexible way to remove those.