Skip to content

Tighten CI .env enforcement and align identity-scan wording#93

Merged
djkingy79-yo merged 3 commits into
mainfrom
copilot/fix-review-comment-3363391719
Jun 9, 2026
Merged

Tighten CI .env enforcement and align identity-scan wording#93
djkingy79-yo merged 3 commits into
mainfrom
copilot/fix-review-comment-3363391719

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The linked review comment called out a mismatch in CI: the workflow only blocked backend/.env, while repo policy prohibits committing either app .env file. The adjacent identity-scan comment also claimed .env files were scanned even though that step does not include them.

  • CI guardrails

    • Extend the .env commit check to fail for both backend/.env and frontend/.env.
    • Update the success message to reflect both enforced paths.
  • Workflow comment accuracy

    • Narrow the identity-leak step comment so it describes the files actually scanned: shipped source, public HTML, and dev plugins.
  • Result

    • CI policy and workflow messaging now match the repository’s actual .env rules.
- name: Check .env not committed
  run: |
    if [ -f "backend/.env" ]; then
      echo "::error::backend/.env should not be committed"
      exit 1
    fi
    if [ -f "frontend/.env" ]; then
      echo "::error::frontend/.env should not be committed"
      exit 1
    fi
    echo "✅ backend/.env and frontend/.env are not committed"

Copilot AI changed the title [WIP] Fix code for review comment 3363391719 Tighten CI .env enforcement and align identity-scan wording Jun 9, 2026
Copilot AI requested a review from djkingy79-yo June 9, 2026 07:35
@djkingy79-yo

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

@djkingy79-yo djkingy79-yo marked this pull request as ready for review June 9, 2026 08:12
Copilot AI review requested due to automatic review settings June 9, 2026 08:12
@djkingy79-yo

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

@djkingy79-yo djkingy79-yo merged commit d760b97 into main Jun 9, 2026
@djkingy79-yo djkingy79-yo deleted the copilot/fix-review-comment-3363391719 branch June 9, 2026 08:14

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Resolved in 9981f3c.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI restored the copilot/fix-review-comment-3363391719 branch June 9, 2026 08:14
Copilot AI requested a review from djkingy79-yo June 9, 2026 08:15
djkingy79-yo added a commit that referenced this pull request Jun 11, 2026
Merge pull request #93 from djkingy79-yo/copilot/fix-review-comment-3…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants