Align identity-lock docs and CI with PR #90 review feedback#92
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code as per review comments
Align identity-lock docs and CI with PR #90 review feedback
Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the IDENTITY_LOCK verification documentation and CI checks to reflect PR #90 review feedback, ensuring the documented grep snippets are shell-runnable and CI more accurately enforces the repository’s no-committed-.env policy.
Changes:
- Fixed
memory/IDENTITY_LOCK.mdverification snippet line continuations / escaping so it can be copied and run in a shell. - Updated CI to fail if either
backend/.envorfrontend/.envis committed, and clarified the identity-leak scan comment to match actual scan scope.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| memory/IDENTITY_LOCK.md | Makes the identity-leak verification grep snippet runnable (proper line continuations and escaping). |
| .github/workflows/ci.yml | Expands .env commit enforcement to backend + frontend and clarifies identity-leak scan scope comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+202
to
205
| if [ -f "backend/.env" ] || [ -f "frontend/.env" ]; then | ||
| echo "::error::backend/.env and frontend/.env should not be committed" | ||
| exit 1 | ||
| fi |
Copilot stopped work on behalf of
djkingy79-yo due to an error
June 11, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the two spots called out in the review thread: the
IDENTITY_LOCKverification snippet and the CI enforcement around committed.envfiles. The goal is to keep the documented checks runnable and make CI match the repository’s actual no-.envpolicy.Docs: make verification commands shell-runnable
memory/IDENTITY_LOCK.mdwith actual shell continuations.CI: enforce both forbidden
.envfilesbackend/.envonly to bothbackend/.envandfrontend/.env.CI: clarify identity-leak scan scope
.envfiles.