Skip to content

Align identity-lock docs and CI with PR #90 review feedback#92

Merged
djkingy79-yo merged 2 commits into
mainfrom
copilot/fix-comments-in-review-thread
Jun 9, 2026
Merged

Align identity-lock docs and CI with PR #90 review feedback#92
djkingy79-yo merged 2 commits into
mainfrom
copilot/fix-comments-in-review-thread

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This updates the two spots called out in the review thread: the IDENTITY_LOCK verification snippet and the CI enforcement around committed .env files. The goal is to keep the documented checks runnable and make CI match the repository’s actual no-.env policy.

  • Docs: make verification commands shell-runnable

    • Replaced doubled line-continuation slashes in memory/IDENTITY_LOCK.md with actual shell continuations.
    • Normalized regex escaping in the example so the command can be copied directly into a shell.
    grep -rEn \
      -e "posthog" \
      -e "google-analytics" \
      -e "gtag\(" \
      /app/backend /app/frontend/src
  • CI: enforce both forbidden .env files

    • Expanded the workflow check from backend/.env only to both backend/.env and frontend/.env.
    • Updated the step name and messages to reflect the broader policy.
  • CI: clarify identity-leak scan scope

    • Removed the misleading comment that implied the identity-leak grep scans .env files.
    • Kept the scan focused on shipped source, public assets, and plugins, matching what the command actually inspects.

Copilot AI changed the title [WIP] Fix code as per review comments Align identity-lock docs and CI with PR #90 review feedback Jun 9, 2026
Copilot AI requested a review from djkingy79-yo June 9, 2026 07:28
@djkingy79-yo djkingy79-yo marked this pull request as ready for review June 9, 2026 08:10
Copilot AI review requested due to automatic review settings June 9, 2026 08:10
@djkingy79-yo djkingy79-yo merged commit f448b47 into main Jun 9, 2026
5 checks passed
@djkingy79-yo djkingy79-yo deleted the copilot/fix-comments-in-review-thread branch June 9, 2026 08:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the IDENTITY_LOCK verification documentation and CI checks to reflect PR #90 review feedback, ensuring the documented grep snippets are shell-runnable and CI more accurately enforces the repository’s no-committed-.env policy.

Changes:

  • Fixed memory/IDENTITY_LOCK.md verification snippet line continuations / escaping so it can be copied and run in a shell.
  • Updated CI to fail if either backend/.env or frontend/.env is committed, and clarified the identity-leak scan comment to match actual scan scope.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
memory/IDENTITY_LOCK.md Makes the identity-leak verification grep snippet runnable (proper line continuations and escaping).
.github/workflows/ci.yml Expands .env commit enforcement to backend + frontend and clarifies identity-leak scan scope comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines +202 to 205
if [ -f "backend/.env" ] || [ -f "frontend/.env" ]; then
echo "::error::backend/.env and frontend/.env should not be committed"
exit 1
fi
Copilot stopped work on behalf of djkingy79-yo due to an error June 11, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants