Added filters to take more than one filter parameters, enabled empty filter params, changed campus parameters#19
Open
djennedy wants to merge 3 commits into
Open
Added filters to take more than one filter parameters, enabled empty filter params, changed campus parameters#19djennedy wants to merge 3 commits into
djennedy wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added filter functions that now take more than one filter parameter as a list.
The filters that can take more than one filter parameter:
All of these filters have checkbox parameters so we be able to filter with more than one parameter. They also take empty lists as a no-filters option
The filters that doesn't take more than one filter parameters:
Both of these filters are text input from the user so it doesn't make sense to have more than one filter parameter
Chaining all of these filters work with each other, for example, I tested:
I also made a change for campus filtering, now instead of taking a "Vancouver" option, the checkbox will show "Online" and "Other" instead. Reasoning is because there are multiple Vancouver campuses and all of them are encoded differently in the API, so we'd rather just bunch them together than deal with edge cases one by one