Exit runserver when Daphne startup aborts#583
Open
lin-hongkuan wants to merge 2 commits into
Open
Conversation
c034688 to
9b37c14
Compare
cf2209a to
ece3e67
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runservercommand checkServer.abort_startafterServer.run()returnsCommandErrorwhen Daphne aborts during startup, matching the standalone CLI behavior of exiting non-zeroFixes #577
Tests
python -m pytest tests\test_runserver_startup.py tests\test_cli.py -qpython -m pytest -q tests --ignore=tests/test_packaging.pypython -m black --check daphne\management\commands\runserver.py tests\test_runserver_startup.pypython -m flake8 daphne\management\commands\runserver.py tests\test_runserver_startup.pygit diff --checkNote:
python -m pytest -qfails in my local editable-install environment only attests/test_packaging.py::test_fd_endpoint_plugin_installed, because the Twisted plugin file is not present under the selectedsite-packagespath. The runtime tests pass with that packaging-only test excluded.