fix(types): make props optional when provided via animatedProps#31
Open
hannojg wants to merge 1 commit into
Open
fix(types): make props optional when provided via animatedProps#31hannojg wants to merge 1 commit into
hannojg wants to merge 1 commit into
Conversation
When using createAnimatedComponent with useAnimatedProps, props that are
provided through animatedProps now become optional on the component itself.
This fixes the TypeScript error where required props would still be required
on the component even when they were being provided via animatedProps.
Example:
```tsx
interface ViewProps {
requiredBorderRadius: number;
}
function MyComp(props: ViewProps) {}
const AnimatedComp = Animated.createAnimatedComponent(MyComp);
const animatedProps = useAnimatedProps(() => ({
requiredBorderRadius: sharedValue.get()
}));
// Previously errored, now works correctly
<AnimatedComp animatedProps={animatedProps} />
```
Changes:
- AnimatedProps<Props, AP> now takes optional second type parameter
- useAnimatedProps preserves exact return type for better inference
- Added AnimatedComponentType for generic animatedProps inference
- Updated type tests to reflect new behavior
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using createAnimatedComponent with useAnimatedProps, props that are provided through animatedProps now become optional on the component itself.
This fixes the TypeScript error where required props would still be required on the component even when they were being provided via animatedProps.
Example:
Changes:
Summary
Test plan