This repository was archived by the owner on Apr 27, 2024. It is now read-only.
feat: add lastPinTimestamp to DMChannel, update lastPinTimestamp#320
Open
tjrgg wants to merge 3 commits intodirigeants:masterfrom
Open
feat: add lastPinTimestamp to DMChannel, update lastPinTimestamp#320tjrgg wants to merge 3 commits intodirigeants:masterfrom
tjrgg wants to merge 3 commits intodirigeants:masterfrom
Conversation
vladfrangu
approved these changes
Jul 27, 2020
kyranet
reviewed
Jul 27, 2020
| const channel = guild ? guild.channels.get(data.d.channel_id) : this.client.dms.get(data.d.channel_id); | ||
| if (!channel || !isTextBasedChannel(channel)) return; | ||
|
|
||
| channel.lastPinTimestamp = data.d.last_pin_timestamp ?? null; |
Contributor
There was a problem hiding this comment.
Can last_pin_timestamp ever be undefined? If so, you should guard the set with the isSet util from this library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lastPinTimestampproperty to DMChannel.lastPinTimestampwhen CHANNEL_PINS_UPDATE action runs.