Conversation
cb56d85 to
8f54b41
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sahil590
left a comment
There was a problem hiding this comment.
Looks like its working.
Not really sure what else would be needed for this.
|
I think both of those points would be addressed by using the registry caching mechanism - https://docs.docker.com/build/ci/github-actions/cache/#registry-cache |
93deade to
8c5acd8
Compare
8c5acd8 to
aa21f0e
Compare
|
EDIT: NEVERMIND! I missed a silly thing!
@cc-a I've attempted this, but it hasn't worked. Not sure if it's something I've missed because I'm using a separate action file for both now, or if it's a misunderstanding of the cache |
|
@cc-a I think this is ready for a review. I believe it is working. |
Description
This PR includes a step to build the docker image at the end of the CI tests. This is so that we can be certain the docker image will build correctly when we do the release.
Some missing elements:
main, instead of building it again. I have not implemented this because I am not sure how.@cc-a Any thoughts on how to do the two missing elements above?
Fixes #594
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks