Skip to content

Test image builds#654

Open
AdrianDAlessandro wants to merge 11 commits intomainfrom
test-image-builds
Open

Test image builds#654
AdrianDAlessandro wants to merge 11 commits intomainfrom
test-image-builds

Conversation

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator

Description

This PR includes a step to build the docker image at the end of the CI tests. This is so that we can be certain the docker image will build correctly when we do the release.

Some missing elements:

  • There is no caching, so it downloads all the dependencies every time (I am not sure how to do this)
  • When it comes to making the release, it's probably more efficient to just take the previously built image from main, instead of building it again. I have not implemented this because I am not sure how.

@cc-a Any thoughts on how to do the two missing elements above?

Fixes #594

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@Sahil590 Sahil590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like its working.
Not really sure what else would be needed for this.

@cc-a
Copy link
Copy Markdown
Contributor

cc-a commented Mar 26, 2026

I think both of those points would be addressed by using the registry caching mechanism - https://docs.docker.com/build/ci/github-actions/cache/#registry-cache

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator Author

AdrianDAlessandro commented Mar 27, 2026

EDIT: NEVERMIND! I missed a silly thing!

I think both of those points would be addressed by using the registry caching mechanism - https://docs.docker.com/build/ci/github-actions/cache/#registry-cache

@cc-a I've attempted this, but it hasn't worked. Not sure if it's something I've missed because I'm using a separate action file for both now, or if it's a misunderstanding of the cache

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator Author

@cc-a I think this is ready for a review. I believe it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test image builds before release

3 participants