fix: commit AppIcon.icns and streamline release workflow#3
Merged
Conversation
The .icns was gitignored, so CI runners fell back to the placeholder (blue circle). Now the V2 icon is committed and used in both the DMG and .app bundle. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tags are only pushed from main which has already passed CI. The release job builds everything itself, so the nested CI call was just wasting runner minutes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packaging/AppIcon.icnsfrom.gitignoreand commit the V2 icon so CI builds use it instead of falling back to the blue circle placeholdercijob from the release workflow — tags are pushed frommainwhich has already passed CITest plan
🤖 Generated with Claude Code