Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,17 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
# MUST match `go.mod`'s `go` directive (currently 1.24.0)
# AND `.github/workflows/ci.yml`'s lint job — the test
# jobs use `go-version-file: 'go.mod'` which auto-derives,
# so we have to keep this in sync by hand. With Go's
# default `GOTOOLCHAIN=auto`, a too-old pin here would
# "self-heal" via auto-download — masking the divergence
# from CI but silently depending on network access to
# proxy.golang.org at release time, and breaking outright
# if `GOTOOLCHAIN=local` is ever set (org policy, air-
# gapped runner). See #66.
go-version: '1.24'
cache: true

- name: Run GoReleaser
Expand Down
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
slip entry throws, the absolute-outside entry throws).
No JS test framework introduced; same reasoning as #63.
Closes #65 (points 1 and 3).
- `.github/workflows/release.yml`: bump the GoReleaser job's
`go-version` pin from `'1.22'` to `'1.24'` to match
`go.mod`'s `go 1.24.0` directive and `.github/workflows/ci.yml`'s
lint job (the test jobs in ci.yml use `go-version-file: 'go.mod'`
which auto-derives, so we have to keep the explicit pin here in
sync by hand). Pre-fix, the comment at release.yml:6 claiming
"same version pin as CI" was misleading — the divergence was
masked by Go's default `GOTOOLCHAIN=auto` (which auto-downloads
the missing toolchain), but that meant the release build
silently depended on network access to proxy.golang.org during
the release job — a step CI never exercises, since CI already
has 1.24. If `GOTOOLCHAIN=local` is ever set (org policy,
air-gapped runner), the release build would break outright at
tag-push time, the one moment there's no opportunity to catch
it in a normal PR-gated CI run. A multi-line inline comment
next to the pin explains the parity-with-go.mod invariant so
future bumps in either direction are caught in code review.
Closes #66.

## [0.0.0] - 2024-07-01

Expand Down
Loading