chore(ci): gitignore the local bin/ and coverage.out#40
Merged
Conversation
`make build` writes ./bin/nodeup and `make test` writes coverage.out, both of which are local artefacts. Neither is something the repo should ever commit, but neither was in .gitignore - so they showed up as untracked on every `git status`, cluttering the view of what's actually changed during a PR. Add /bin/ with a comment explaining that the npm wrapper's postinstall script populates a *different* `bin/` under `nodeup-npm/node_modules/` (handled by `nodeup-npm/.npmignore`, not the root gitignore). Also add `coverage.out` next to the existing `coverage.html` / `coverage.txt` lines. Co-Authored-By: Sonnet 4.6 <noreply@puku.sh>
|
✔️ 208c0da - Conventional commits check succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make buildwrites./bin/nodeupandmake testwritescoverage.out, but neither path was in.gitignore— so theyshowed up as untracked on every
git status, cluttering theview of what's actually changed during a PR.
Both are local artefacts that should never be committed. This
PR adds them to
.gitignorewith a comment explaining that thenpm wrapper's
install.jspopulates a differentbin/undernodeup-npm/node_modules/(handled bynodeup-npm/.npmignore,not the root gitignore).
Type of change
feat— new feature (MINOR bump)fix— bug fix (PATCH bump)refactor— no behavior changedocs— documentation onlychore— maintenanceci— CI/CD onlybuild— build system onlyChecklist
chore(ci): subject)make cilocally —.gitignore-only change, no code changeScope notes / things reviewers may want to look at
git ls-files bin/andgit ls-files coverage.outboth return empty — nothingtracked is in either path. The PR is safe to merge even if a
contributor has stale local builds lying around.
.gitignorecleanup is unrelated tothe OIDC publish work in chore(ci): publish nodeup-cli to npm via OIDC Trusted Publishing #39 and the npm wrapper rename in chore(release): rename npm wrapper to nodeup-cli #37.
Keeping it in its own PR makes both the diff and the merge
history easier to reason about —
#39is a CI change,#40isa dev-hygiene change.
How to verify