Skip to content

chore(ci): gitignore the local bin/ and coverage.out#40

Merged
dipto0321 merged 1 commit into
mainfrom
chore/ci/gitignore-bin
Jul 1, 2026
Merged

chore(ci): gitignore the local bin/ and coverage.out#40
dipto0321 merged 1 commit into
mainfrom
chore/ci/gitignore-bin

Conversation

@dipto0321

Copy link
Copy Markdown
Owner

Summary

make build writes ./bin/nodeup and make test writes
coverage.out, but neither path was in .gitignore — so they
showed up as untracked on every git status, cluttering the
view of what's actually changed during a PR.

Both are local artefacts that should never be committed. This
PR adds them to .gitignore with a comment explaining that the
npm wrapper's install.js populates a different bin/ under
nodeup-npm/node_modules/ (handled by nodeup-npm/.npmignore,
not the root gitignore).

Type of change

  • feat — new feature (MINOR bump)
  • fix — bug fix (PATCH bump)
  • refactor — no behavior change
  • docs — documentation only
  • chore — maintenance
  • ci — CI/CD only
  • build — build system only
  • Breaking change (MAJOR bump) — explain below

Checklist

  • Title follows Conventional Commits (chore(ci): subject)
  • I ran make ci locally — .gitignore-only change, no code change
  • I added or updated tests — N/A
  • I updated relevant docs — N/A
  • No new linter warnings

Scope notes / things reviewers may want to look at

  • No risk of accidentally ignoring tracked files. git ls-files bin/ and git ls-files coverage.out both return empty — nothing
    tracked is in either path. The PR is safe to merge even if a
    contributor has stale local builds lying around.
  • Why a separate PR. The .gitignore cleanup is unrelated to
    the OIDC publish work in chore(ci): publish nodeup-cli to npm via OIDC Trusted Publishing #39 and the npm wrapper rename in chore(release): rename npm wrapper to nodeup-cli #37.
    Keeping it in its own PR makes both the diff and the merge
    history easier to reason about — #39 is a CI change, #40 is
    a dev-hygiene change.

How to verify

# before: untracked bin/ and coverage.out visible
git checkout main && make build && make test
git status   # shows bin/nodeup and coverage.out as untracked

# after merge
git pull
make build && make test
git status   # clean working tree

`make build` writes ./bin/nodeup and `make test` writes
coverage.out, both of which are local artefacts. Neither is
something the repo should ever commit, but neither was in
.gitignore - so they showed up as untracked on every `git status`,
cluttering the view of what's actually changed during a PR.

Add /bin/ with a comment explaining that the npm wrapper's
postinstall script populates a *different* `bin/` under
`nodeup-npm/node_modules/` (handled by `nodeup-npm/.npmignore`,
not the root gitignore). Also add `coverage.out` next to the
existing `coverage.html` / `coverage.txt` lines.

Co-Authored-By: Sonnet 4.6 <noreply@puku.sh>
@cocogitto-bot

cocogitto-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

✔️ 208c0da - Conventional commits check succeeded.

@dipto0321 dipto0321 merged commit 48f14c3 into main Jul 1, 2026
10 checks passed
@dipto0321 dipto0321 deleted the chore/ci/gitignore-bin branch July 1, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant