Feature/screenshot watermark#109
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Adds configurable screenshot watermarking for overlay copy/save flows, including persisted settings, rendering service, settings UI, DI wiring, and tests. The PR also broadens GlobalUsings.cs and removes now-global imports across many files.
Changes:
- Adds
ScreenshotWatermarkSettings,WatermarkPosition, token resolution, and a WPF renderer. - Applies watermarks in
OverlayViewModelfor Copy, Save, and Save As based on user settings. - Adds Settings UI bindings and unit tests for token resolution, layout positioning, and overlay watermark behavior.
Reviewed changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Pointframe/Models/ScreenshotWatermarkSettings.cs |
Adds persisted watermark configuration model. |
Pointframe/Models/WatermarkPosition.cs |
Adds watermark placement enum. |
Pointframe/Models/UserSettings.cs |
Adds watermark settings to user settings. |
Pointframe/Services/Recording/IScreenshotWatermarkService.cs |
Adds watermark renderer interface. |
Pointframe/Services/Recording/ScreenshotWatermarkService.cs |
Implements watermark rendering over screenshots. |
Pointframe/Services/Recording/WatermarkTokenResolver.cs |
Adds date/time token replacement. |
Pointframe/ViewModels/OverlayViewModel.cs |
Applies watermark during copy/save flows. |
Pointframe/ViewModels/SettingsViewModel.cs |
Adds watermark settings bindings and save persistence. |
Pointframe/Views/SettingsWindow.xaml |
Adds watermark controls to settings UI. |
Pointframe/Services/Infrastructure/UserSettingsService.cs |
Clones watermark settings. |
Pointframe/App.xaml.cs |
Registers watermark service with DI. |
Pointframe/GlobalUsings.cs |
Adds project-wide global usings. |
Pointframe.Tests/ViewModels/OverlayViewModelTests.cs |
Adds overlay watermark behavior tests. |
Pointframe.Tests/Services/WatermarkTokenResolverTests.cs |
Adds token resolver tests. |
Pointframe.Tests/Services/ScreenshotWatermarkServiceLayoutTests.cs |
Adds watermark position tests. |
| Other touched app/test files | Remove imports now covered by global usings or update constructor calls for OverlayViewModel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CultureInfo.CurrentCulture, | ||
| System.Windows.FlowDirection.LeftToRight, | ||
| typeface, | ||
| settings.FontSize, |
Comment on lines
+126
to
+144
| [ObservableProperty] | ||
| private bool _watermarkEnabled; | ||
|
|
||
| [ObservableProperty] | ||
| private string _watermarkTemplate = "{datetime}"; | ||
|
|
||
| [ObservableProperty] | ||
| private WatermarkPosition _watermarkPosition; | ||
|
|
||
| [ObservableProperty] | ||
| private double _watermarkFontSize; | ||
|
|
||
| [ObservableProperty] | ||
| private bool _watermarkApplyToCopy; | ||
|
|
||
| [ObservableProperty] | ||
| private bool _watermarkApplyToSave; | ||
|
|
||
| public IReadOnlyList<WatermarkPosition> WatermarkPositions { get; } = Enum.GetValues<WatermarkPosition>(); |
…nd OverlayViewModel tests
- Use default font size in ScreenshotWatermarkService if FontSize is non-positive - Reset watermark fields in SettingsViewModel for both section and global resets - Add unit tests for font size fallback and watermark field resets
Incremented version.json from 6.2 to 6.3 to mark a new release. No other changes were made in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.