Flip writeback to iterate over rapier's bodies#432
Open
Aceeri wants to merge 3 commits intodimforge:masterfrom
Open
Flip writeback to iterate over rapier's bodies#432Aceeri wants to merge 3 commits intodimforge:masterfrom
Aceeri wants to merge 3 commits intodimforge:masterfrom
Conversation
Contributor
Author
|
It seems that this gives a ~22% performance increase in the |
cf6a974 to
987a148
Compare
Member
|
Thank you for this PR! Is there a particular reason why the I’m very surprised this improves performances. Doesn’t bevy recommend iterating on bodies rather than random access through |
Contributor
Author
|
Yeah I wasn't expecting this to do anything honestly, I was just testing this out for the sake of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure of whether this will have a noticeable performance improvement currently. I would like to do some benchmarks on how writeback performs.
I think the bigger thing here would be to not use bevy's transform propagation/
GlobalTransformand instead adapt it to our case where we update aPhysicsTransformthat is more akin to the old pre-0.8 bevyGlobalTransform. This would also allow us to not update unrelated entities.