Quotes in formatCode case handled, standard format 22 changed to m/d/yy hh:mm#186
Open
ash-ishh wants to merge 5 commits intodilshod:masterfrom
Open
Quotes in formatCode case handled, standard format 22 changed to m/d/yy hh:mm#186ash-ishh wants to merge 5 commits intodilshod:masterfrom
ash-ishh wants to merge 5 commits intodilshod:masterfrom
Conversation
…x2csv into dateformat-improved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1: While converting date of following excel file format was detected as mmm d", "yyyy and converted to March 14", "2019
formatCode in xml header was
<numFmt numFmtId="165" formatCode="MMMM\ D", "YYYY"/>Since date does not generally contain quotes hence removed all quotes in formatCode extracted.
Problem 2: Date 09/01/19 13:00 was detected as dd/mm/yy h:mm and converted to CSV as 09/01/19 01:00 from standard format 22
Since date without am/pm is generally in 24 hour format hence changed it to m/d/yy hh:mm