Fix build with latest MSVC#100
Closed
mos9527 wants to merge 2 commits into
Closed
Conversation
Overload resolution must have changed and is causing issues for one particular code path attempting to use `isfinite(ccl::uchar)`. Compiler output attached. It turns out that the code in question can be simplified to just remove the ambiguity because only the float codepath wants to check for finite values. ---- Reduced repro: https://godbolt.org/z/YWz3Yc3x8 Pull Request: https://projects.blender.org/blender/blender/pulls/125348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address two issues when building with the latest MSVC
Releated issues/PRs:
system_clockfrom<__msvc_chrono.hpp>to<chrono>microsoft/STL#5105isfinitein image.cpp #99This PR also in effect supersedes #92