Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI coverage for NanoRoot builds and adjusts the TAP-related CMake subproject inclusion order to address build/link ordering issues in the NanoTAP2 components.
Changes:
- Reordered TAP subdirectories in the root
CMakeLists.txtto buildnanotap2_commonbefore dependent components. - Added a new GitHub Actions workflow to build NanoRoot with TAP Local enabled on a schedule/manual trigger (and currently on a branch-restricted push trigger).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CMakeLists.txt | Reorders TAP subdirectory additions to improve build/link ordering for NanoTAP2 libs. |
| .github/workflows/build_nanoroot.yml | Introduces a scheduled/manual NanoRoot build workflow (plus a branch-restricted push trigger). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NanoRoot build testing
Also
CMake tries to build libnanotap2.so first but libnanotap2.so depends on libnanotap2_common.so
So changing the order of build in CMakeLists.txt file