[AUDIO] refactor, add play lifetimes, add pan setting, general source tidy#58
Merged
differrari merged 7 commits intodifferrari:mainfrom Nov 18, 2025
Merged
[AUDIO] refactor, add play lifetimes, add pan setting, general source tidy#58differrari merged 7 commits intodifferrari:mainfrom
differrari merged 7 commits intodifferrari:mainfrom
Conversation
differrari
reviewed
Oct 25, 2025
kernel/audio/audio.cpp
Outdated
| line->u.buf[1].left_level = 0; | ||
| line->u.buf[1].right_level = 0; | ||
| line->bix = 0; | ||
| line->dbl.buf[0].ptr = NULL; |
Owner
There was a problem hiding this comment.
Would a memset be faster and more reliable with sizeof here? Or is there limitations
Contributor
Author
There was a problem hiding this comment.
Good point. I'll get that sorted.
shared/audio/cuatro.c
Outdated
| return lineId; | ||
| } | ||
|
|
||
| #ifdef KERNEL |
Owner
There was a problem hiding this comment.
Sorry for the confusion, as of the latest version of the lib, fopen/read/write will call the non-syscall version of the function
Contributor
Author
There was a problem hiding this comment.
Ah, that simplifies things. I'll tidy that up.
differrari
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are breaking changes in terms of function names & parameters. I expect these to remain stable now.
See my 'audiopong' repo for example app usage.