Open
Conversation
rjmunro
approved these changes
Sep 27, 2022
|
|
||
| # Ubuntu packages | ||
| RUN apt-get update && \ | ||
| RUN apt-get update && apt-get upgrade -y && apt-get autoremove -y && \ |
There was a problem hiding this comment.
It shouldn't make any difference but I would move the autoremove after all the installs - put it last before the apt-get clean, then all the cleanup stuff is happening last and will clean everything it can.
pcrane
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes suggested by PhilipJohnson: https://gist.github.com/phillipjohnson/290412e8c4291dcd23e320c981f96867
To create the image
redash/redashwith version11.0.0:$ docker build -t redash/redash:11.0.0 .Then running
grypeon this gives these resultsgrype-11.0.0-only-fixed.txt
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)