SystemVerilog: create identifier expressions in scanner#953
Merged
tautschnig merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
kroening
force-pushed
the
identifier-tokens2
branch
from
9e467b2 to
8d03c57
Compare
kroening
force-pushed
the
identifier-tokens2
branch
from
8d03c57 to
ec87b80
Compare
kroening
force-pushed
the
identifier-tokens2
branch
4 times, most recently
from
7275cdc to
d9a56ac
Compare
The verilog_identifer expressions are now created in the scanner, not the parser. The benefit of doing so is that the lookup needed in the scanner to determine the token type does not need to be repeated in the parser to identify the scope in which the identifier was defined in.
kroening
force-pushed
the
identifier-tokens2
branch
from
d9a56ac to
2ba4667
Compare
tautschnig
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verilog_identiferexpressions are now created in the scanner, not the parser.The benefit of doing so is that the lookup needed in the scanner to determine the token type does not need to be repeated in the parser to identify the scope in which the identifier was defined in.