Support reordered pointer operands in local_bitvector_analysis#8785
Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
Open
Support reordered pointer operands in local_bitvector_analysis#8785tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8785 +/- ##
========================================
Coverage 79.93% 79.93%
========================================
Files 1698 1698
Lines 187698 187703 +5
Branches 73 73
========================================
+ Hits 150034 150047 +13
+ Misses 37664 37656 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`local_bitvector_analysist` previously assumed that pointer arithmetic expressions with 3+ operands always have the pointer operand at position `op0()`. We do not, however, have such a requirement anywhere, and even if front-ends construct expressions this way then simplification may re-order the operands. Fixes: diffblue#2689
1d9087e to
470747a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
local_bitvector_analysistpreviously assumed that pointer arithmetic expressions with 3+ operands always have the pointer operand at positionop0(). We do not, however, have such a requirement anywhere, and even if front-ends construct expressions this way then simplification may re-order the operands.Fixes: #2689