fix(ci): separate unit/E2E tests and fix commitlint ESM config#11
Merged
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 33202264 | Triggered | Username Password | 17895aa | .github/workflows/ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testesjob into two sequential jobs:testes-unitarios(no external services) andtestes-e2e(MongoDB + Redis)commitlint.config.js→commitlint.config.cjsto fix ESM incompatibility in CIRoot Causes
1 — E2E tests running without database services
The
testesjob ranpnpm test, which executesvitest runagainstsrc/testes/**/*.test.ts— including the four E2E suites. Those suites callconectarBdTeste()andobterRedis()inbeforeAll, but the runner had no MongoDB or Redis available. ThebeforeAllhook timed out at 10 000 ms, thenbdwasundefined, causing the cascade:2 — commitlint ESM incompatibility
commitlint.config.jsusedexport default(ESM) becausepackage.jsondeclares"type": "module". Thewagoid/commitlint-github-action@v6Docker container cannot reliably load ESM config files, producing a genericError: You have commit messages with errorsregardless of commit content.Changes
ci.ymltestesjob:pnpm test(all tests, no services)testes-unitarios:vitest run src/testes/unitarios(no services)testes-e2e:vitest run src/testes/e2ewith MongoDB 8.0 + Redis 8 servicescobertura:vitest run --coverage src/testes/unitariosService credentials match
auxiliar-bd.tsdefaults:administrador:1qaz2sx12(auth source: admin)REDIS_URL=redis://localhost:6379)Pipeline order:
commitlint.config.js→commitlint.config.cjsRenamed and converted to CommonJS (
module.exports = {...}). Identical rules, universal compatibility. Updatedcommitlint.ymlto reference the.cjsfile.Test plan
E2E tests are validated by the new
testes-e2eCI job running against the service containers.🤖 Generated with Claude Code