Skip to content

fix(docs): address Flight review findings for circuit breaker guide#87

Closed
diberry wants to merge 1 commit intodevfrom
squad/fix-circuit-breaker-review
Closed

fix(docs): address Flight review findings for circuit breaker guide#87
diberry wants to merge 1 commit intodevfrom
squad/fix-circuit-breaker-review

Conversation

@diberry
Copy link
Copy Markdown
Owner

@diberry diberry commented Mar 28, 2026

Fork PR for Copilot review gate. Upstream PR will be re-opened after this passes.

- Replace phantom @squad/resilience import with pseudocode
- Fix squad.json → squad.config.ts convention
- Add successThreshold explanation
- Fix pseudocode catch block double-recording on open circuit

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@diberry diberry added squad:pr-needs-review PR lifecycle: awaiting team review squad:archive Resolved by upstream or no longer applicable and removed squad:pr-needs-review PR lifecycle: awaiting team review labels Mar 31, 2026
@diberry
Copy link
Copy Markdown
Owner Author

diberry commented Apr 1, 2026

Closing — superseded by upstream work. See squad:archive label for details.

@diberry diberry closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad:archive Resolved by upstream or no longer applicable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant