Skip to content

chore: use scikit-build-core for the build#337

Open
henryiii wants to merge 1 commit into
dhermes:mainfrom
henryiii:henryiii/chore/skbc
Open

chore: use scikit-build-core for the build#337
henryiii wants to merge 1 commit into
dhermes:mainfrom
henryiii:henryiii/chore/skbc

Conversation

@henryiii

Copy link
Copy Markdown

Getting started on #336 to see what it looks like.

@dhermes dhermes marked this pull request as ready for review October 1, 2024 14:39
@dhermes

dhermes commented Oct 1, 2024

Copy link
Copy Markdown
Owner

@henryiii Somehow I missed this in July, sorry! Just marked it "Ready for Review". Note that you'll want to rebase / merge main because some things have been updated (e.g. _speedup.c CI check fails if not up to date with latest Cython)

UPDATE: I now realize "Ready for Review" was the wrong button! I needed to click "Approve and run". DERP!

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/chore/skbc branch from c2134ec to 6e71632 Compare October 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants