Skip to content

Calcualte true normals rather than sign#30

Merged
dgaylo merged 6 commits into
masterfrom
true-normals
Jul 29, 2025
Merged

Calcualte true normals rather than sign#30
dgaylo merged 6 commits into
masterfrom
true-normals

Conversation

@dgaylo

@dgaylo dgaylo commented Jul 29, 2025

Copy link
Copy Markdown
Owner

Closes #28

@github-actions

Copy link
Copy Markdown

Benchmark Results


--------------------------------------------------------------------------------- benchmark 'test_bench_Chan': 2 tests --------------------------------------------------------------------------------
Name (time in us)               Min                   Max                Mean             StdDev              Median                IQR            Outliers  OPS (Kops/s)            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_Chan (head)     573.7730 (1.0)        985.9840 (1.0)      602.4269 (1.0)      29.6843 (1.0)      599.9875 (1.0)      17.7330 (1.0)         59;58        1.6600 (1.0)        1746           1
test_bench_Chan (base)     578.0400 (1.01)     1,242.1300 (1.26)     611.3754 (1.01)     37.8030 (1.27)     607.4900 (1.01)     18.9860 (1.07)        61;73        1.6357 (0.99)       1728           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------- benchmark 'test_bench_WY': 2 tests ------------------------------------------------------------------------
Name (time in ms)           Min               Max              Mean            StdDev            Median               IQR            Outliers       OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_WY (head)     3.4428 (1.0)      4.2339 (1.0)      3.4950 (1.0)      0.0698 (1.0)      3.4796 (1.0)      0.0315 (1.0)         13;19  286.1243 (1.0)         290           1
test_bench_WY (base)     3.4732 (1.01)     4.2525 (1.00)     3.5409 (1.01)     0.0767 (1.10)     3.5239 (1.01)     0.0441 (1.40)        16;16  282.4126 (0.99)        288           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------- benchmark 'test_bench_base': 2 tests ------------------------------------------------------------------------
Name (time in ms)             Min               Max              Mean            StdDev            Median               IQR            Outliers       OPS            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_base (base)     1.4268 (1.0)      1.8075 (1.0)      1.4641 (1.0)      0.0372 (1.0)      1.4555 (1.0)      0.0235 (1.83)        54;48  683.0117 (1.0)         701           1
test_bench_base (head)     1.9538 (1.37)     3.0486 (1.69)     1.9915 (1.36)     0.0787 (2.12)     1.9741 (1.36)     0.0128 (1.0)         24;56  502.1309 (0.74)        511           1
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------------- benchmark 'test_bench_no_norm': 2 tests --------------------------------------------------------------------------------
Name (time in us)                  Min                 Max                Mean             StdDev              Median                IQR            Outliers  OPS (Kops/s)            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_no_norm (base)     340.5060 (1.0)      646.6580 (1.0)      366.6058 (1.00)     18.1255 (1.0)      363.1830 (1.01)     19.3560 (1.11)       461;79        2.7277 (1.00)       2938           1
test_bench_no_norm (head)     341.4490 (1.00)     685.9040 (1.06)     365.9164 (1.0)      24.1066 (1.33)     361.3260 (1.0)      17.4265 (1.0)        139;92        2.7329 (1.0)        2960           1
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@dgaylo dgaylo added the enhancement New feature or request label Jul 29, 2025
@dgaylo dgaylo merged commit 6a8a497 into master Jul 29, 2025
18 checks passed
@dgaylo dgaylo deleted the true-normals branch July 29, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calculate real normal vector values, not just $\mathrm{sign}(n_x)$

1 participant