DEP Implementation: ExtendPayload interface support #2876#2963
Open
loafoe wants to merge 1 commit into
Open
Conversation
loafoe
force-pushed
the
feature/extend-payload
branch
from
06fb632 to
a416ee5
Compare
|
👍 |
loafoe
force-pushed
the
feature/extend-payload
branch
2 times, most recently
from
b5611ca to
b08a08a
Compare
loafoe
force-pushed
the
feature/extend-payload
branch
from
b08a08a to
1386a56
Compare
loafoe
force-pushed
the
feature/extend-payload
branch
from
1386a56 to
96f1889
Compare
loafoe
force-pushed
the
feature/extend-payload
branch
2 times, most recently
from
d0fe647 to
1064ab3
Compare
loafoe
force-pushed
the
feature/extend-payload
branch
2 times, most recently
from
36c24ac to
be8a6df
Compare
|
Hey, thanks for the frequent updates to your PR! For context, I'm using your DEP in my "Synology Google SSO" fork of Dex: https://maelvls.dev/synology-sso-with-personal-google-account/ |
maelvls
reviewed
Jun 1, 2025
| } | ||
|
|
||
| type PayloadExtender interface { | ||
| ExtendPayload(scopes []string, payload []byte, connectorData []byte) ([]byte, error) |
There was a problem hiding this comment.
Would be great to pass the claims as well as context.Context here, WDYT?
E.g.:
// PayloadExtender allows connectors to enhance the payload before signing. See:
// https://github.com/dexidp/dex/issues/2876.
type PayloadExtender interface {
ExtendPayload(scopes []string, claims storage.Claims, payload []byte, connectorData []byte) ([]byte, error)
}
Signed-off-by: Andy Lo-A-Foe <andy.loafoe@gmail.com>
loafoe
force-pushed
the
feature/extend-payload
branch
2 times, most recently
from
6b2d393 to
76f1298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implementation of #2876
What this PR does / why we need it
Implements DEP-2876
Special notes for your reviewer
Does this PR introduce a user-facing change?