Skip to content

fix(#349): deny self-writes on members badges subcollection #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aditya948351 merged 1 commit into from
May 31, 2026
+4 −1
Merged

fix(#349): deny self-writes on members badges subcollection #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion firestore.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,12 @@ service cloud.firestore {
}

// Badges Subcollection
// Badge grants must come from trusted backend (Cloud Functions / Admin SDK).
// Self-writes are intentionally denied to prevent users from awarding
// themselves arbitrary badges without meeting the criteria.
match /badges/{badgeId} {
allow read: if true;
allow write: if isSuperAdmin() || (request.auth != null && request.auth.uid == userId);
allow write: if isSuperAdmin();
}

// GitHub Repos Subcollection
Expand Down