Skip to content

feat: 아이템 옵션 값 정보 테이블 및 조회 기능 구현#58

Merged
dev-ant merged 3 commits into
devfrom
feat/item-option-api
Oct 8, 2025
Merged

feat: 아이템 옵션 값 정보 테이블 및 조회 기능 구현#58
dev-ant merged 3 commits into
devfrom
feat/item-option-api

Conversation

@dev-ant

@dev-ant dev-ant commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

📋 상세 설명

  • 아이텝 옵션 값 정보 테이블 CREATE문을 flyway script 작성
create table item_option_value_info
(
    option_type      varchar(100) null comment '아이템 옵션 유형',
    option_sub_type  varchar(100) null comment '아이템 옵션 하위 유형',
    option_value     varchar(255) null comment '아이템 옵션 값',
    option_value2    varchar(255) null comment '아이템 옵션 값 2',
    option_desc      text         null comment '아이템 옵션 부가 정보',
    constraint uq_item_option_value_info unique (option_type(10), option_sub_type(10), option_value(10), option_value2(20))
)
    comment '아이템 옵션 정보 테이블';

-- 초기 데이터 적재 쿼리
-- insert into item_option_value_info (option_type, option_sub_type, option_value, option_value2, option_desc) select distinct option_type, option_sub_type, option_value, option_value2, option_desc from auction_item_option;
  • 기본 조회 (findAll)을 위한 컨트롤러, 서비스, 레포지토리 클래스 구현

📊 체크리스트

  • PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
  • 코드가 테스트 되었나요
  • 문서는 업데이트 되었나요
  • 불필요한 코드를 제거했나요
  • 이슈와 라벨이 등록되었나요

Close #57

@dev-ant dev-ant requested a review from Copilot October 8, 2025 06:50
@dev-ant dev-ant self-assigned this Oct 8, 2025
@dev-ant dev-ant added the ✨feature 새로운 기능 추가 label Oct 8, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements an item option value information table and basic query functionality for retrieving item option metadata. The implementation follows a clean architecture pattern with proper separation of concerns.

  • Creates a new item_option_value_info table to store distinct item option metadata
  • Implements complete CRUD architecture (controller, service, repository) for item option info retrieval
  • Refactors existing code to organize imports and rename classes for better clarity

Reviewed Changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.

File Description
V7__create_item_option_info_table.sql Creates the new item option value info table with unique constraints
ItemOptionInfo*.java Implements entity, repository, service, and controller for item option info
AuctionItemOption*.java Renames and refactors item option classes for better naming consistency
Multiple existing files Reorganizes imports and updates references to renamed classes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +26 to +30
public List<ItemOptionInfoResponse> findAll() {
return itemOptionInfoService.findAll().stream()
.map(itemOptionInfoMapper::toItemOptionInfoResponse)
.collect(Collectors.toList());
}

Copilot AI Oct 8, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using toList() instead of collect(Collectors.toList()) for better performance and readability in Java 16+.

Copilot uses AI. Check for mistakes.
@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown

✅ 테스트 결과 for PR

Build: success

🧪 테스트 실행 with Gradle
📈 Coverage: -0.00%

📁 테스트 결과
📁 커버리지 보고서 (HTML)

@codecov

codecov Bot commented Oct 8, 2025

Copy link
Copy Markdown

@dev-ant dev-ant merged commit 3658f29 into dev Oct 8, 2025
1 of 2 checks passed
@dev-ant dev-ant deleted the feat/item-option-api branch October 8, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feature 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

아이템 옵션 값 정보 테이블 및 조회 기능 구현

2 participants