Skip to content

perf: 경매장 테이블 기본 정렬 조건을 단일 인덱스로 추가 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dev-ant merged 1 commit into from
Feb 26, 2026
Merged

perf: 경매장 테이블 기본 정렬 조건을 단일 인덱스로 추가 #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ springdoc:
decorator:
datasource:
p6spy:
enable-logging: false
enable-logging: true

Copilot AI Feb 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The p6spy logging has been enabled (changed from false to true). This change appears unrelated to the PR's stated purpose of adding indexes for performance. P6spy logs all SQL statements which can significantly impact performance in production environments and generate large amounts of log data. If this change is intentional for debugging purposes, it should be documented in the PR description. Otherwise, this should be reverted to false.

Suggested change
enable-logging: true
enable-logging: false

Copilot uses AI. Check for mistakes.

logging:
config: classpath:logback/logback-display.xml
Expand Down
15 changes: 15 additions & 0 deletions src/main/resources/db/migration/V26_create_index_on_auction_tables.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
-- 검색 필터 없이 검색 시 사용되는 기본 검색 속도 보장 인덱스

Copilot AI Feb 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration file name uses an underscore (_) instead of double underscores (__) which is the standard Flyway naming convention. The file is named "V26_create_index_on_auction_tables.sql" but should be named "V26__create_index_on_auction_tables.sql" (with two underscores between version and description). This inconsistency with Flyway conventions could cause migration issues.

Copilot uses AI. Check for mistakes.
CREATE INDEX idx_ah_date_auction_buy
ON auction_history (date_auction_buy);
Comment on lines +2 to +3

Copilot AI Feb 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single-column index on date_auction_buy may be redundant with the existing composite index idx_ah_top_sub_name_date (created in V20) which has date_auction_buy as its last column. While a standalone index on date_auction_buy can be useful for queries without category filters (as mentioned in the comment), consider that this adds storage overhead and maintenance cost during writes. Verify through query execution plans whether MySQL's query optimizer actually uses this single-column index for the "no filter" scenarios, or if it can efficiently use the composite index's leftmost prefix.

Copilot uses AI. Check for mistakes.

-- 검색 필터 없이 검색 시 사용되는 기본 검색 속도 보장 인덱스
CREATE INDEX idx_ah_auction_price_per_unit
ON auction_history (auction_price_per_unit);

-- 검색 필터 없이 검색 시 사용되는 기본 검색 속도 보장 인덱스
CREATE INDEX idx_ar_date_auction_expire
ON auction_realtime_item (date_auction_expire);

-- 검색 필터 없이 검색 시 사용되는 기본 검색 속도 보장 인덱스
CREATE INDEX idx_ar_auction_price_per_unit
ON auction_realtime_item (auction_price_per_unit);