Skip to content

feat: docker-compose kafka 설정 추가#1

Merged
bsko98 merged 4 commits into
mainfrom
feat/kafka-private-ip
Feb 20, 2026
Merged

feat: docker-compose kafka 설정 추가#1
bsko98 merged 4 commits into
mainfrom
feat/kafka-private-ip

Conversation

@dev-ant

@dev-ant dev-ant commented Feb 17, 2026

Copy link
Copy Markdown

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

프로덕션용 docker-compose에서 Kafka의 advertised.listeners를 고정 호스트/포트 값 대신 환경변수 기반으로 설정 가능하게 변경합니다.

Changes:

  • Kafka KAFKA_ADVERTISED_LISTENERS${KAFKA_EXTERNAL_HOST} / ${KAFKA_EXTERNAL_PORT} 환경변수 기반으로 변경
  • (기능 변화 없이) 네트워크 드라이버 라인 포맷만 변경

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker-compose-prod1.yml
KAFKA_CONTROLLER_QUORUM_VOTERS: '1@kafka:9103'
KAFKA_LISTENERS: 'INTERNAL://0.0.0.0:29092,EXTERNAL://0.0.0.0:9102,CONTROLLER://0.0.0.0:9103'
KAFKA_ADVERTISED_LISTENERS: 'INTERNAL://kafka:29092,EXTERNAL://devnogi.ddns.net:9102'
KAFKA_ADVERTISED_LISTENERS: "INTERNAL://kafka:29092,EXTERNAL://${KAFKA_EXTERNAL_HOST}:${KAFKA_EXTERNAL_PORT}"

Copilot AI Feb 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KAFKA_ADVERTISED_LISTENERS now depends on ${KAFKA_EXTERNAL_HOST} / ${KAFKA_EXTERNAL_PORT}, but this compose file doesn’t provide defaults and the port mapping is still hard-coded to 9102:9102. If those env vars are unset (or KAFKA_EXTERNAL_PORT differs from 9102), Kafka will advertise an invalid/unreachable address and clients will fail to connect. Consider enforcing required values via ${VAR:?message} and/or wiring the ports: mapping to the same ${KAFKA_EXTERNAL_PORT} (with a sane default like :-9102) so the advertised port cannot drift from the exposed port.

Copilot uses AI. Check for mistakes.
@bsko98

bsko98 commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

CLUSTER_ID: 아래에 이코드 추가해주세요.

KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1
KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1

@dev-ant dev-ant requested a review from bsko98 February 20, 2026 03:48

@bsko98 bsko98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bsko98 bsko98 merged commit 45b18fb into main Feb 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants