Conversation
Agent-Logs-Url: https://github.com/devlooped/Schematron/sessions/f32a5ddd-99bd-47c6-b680-474fbf82aa8e Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Agent-Logs-Url: https://github.com/devlooped/Schematron/sessions/f32a5ddd-99bd-47c6-b680-474fbf82aa8e Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate from static regex to source-generated regexes
Migrate TagExpressions to source-generated regexes (multi-target netstandard2.0 + net8.0)
Mar 29, 2026
kzu
approved these changes
Mar 29, 2026
Member
🧪 Details on Ubuntu 24.04.4 LTSfrom retest v1.1.0 on .NET 10.0.5 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the static
Regexfields and static constructor inTagExpressions.cswith source-generated regexes onnet8.0+, while retaining compiledRegexfallbacks fornetstandard2.0.TagExpressions.cs
partial#if NET8_0_OR_GREATER:[GeneratedRegex]-decoratedstatic partialmethods (compile-time generated, zero-allocation)#else:static readonly Regexfields withRegexOptions.Compiledexposed through matchingstatic Regex Foo()methods — identical call-site signature across both targetsThe
AllSchematronpattern hardcodes theRegex.Escape-d values ofSchema.LegacyNamespace/Schema.IsoNamespace(required since[GeneratedRegex]demands a compile-time constant); a comment flags the dependency.Schematron.csproj
TargetFramework→TargetFrameworks: netstandard2.0;net8.0PolySharprestored, scoped tonetstandard2.0only (not needed onnet8.0)Call sites
All four call sites (
LogFormatter,XmlFormatter,Config,Test) already useTagExpressions.Foo()method-call syntax from the initial migration step — no further changes needed.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.