Skip to content

Fix GitLab webhook response status code #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigo merged 1 commit into from
Jan 3, 2026
Merged

Fix GitLab webhook response status code #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/transport/http/gitlabwebhookhandler/gitlabwebhookhandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func (h Handler) Handle(ctx *fasthttp.RequestCtx) {
}()

h.Logger.Info("gitlab webhook received successfully")
ctx.SetStatusCode(fasthttp.StatusAccepted)
ctx.SetStatusCode(fasthttp.StatusOK)
}

func (h Handler) checkRequired() error {
Expand Down
12 changes: 6 additions & 6 deletions internal/transport/http/gitlabwebhookhandler/gitlabwebhookhandler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ func TestHandle_Success_ObjectKind(t *testing.T) {

handler.Handle(ctx)

assert.Equal(t, fasthttp.StatusAccepted, ctx.Response.StatusCode())
assert.Equal(t, fasthttp.StatusOK, ctx.Response.StatusCode())
assert.NotEmpty(t, <-messageQueue)
}

Expand Down Expand Up @@ -356,7 +356,7 @@ func TestHandle_Success_EventName(t *testing.T) {

handler.Handle(ctx)

assert.Equal(t, fasthttp.StatusAccepted, ctx.Response.StatusCode())
assert.Equal(t, fasthttp.StatusOK, ctx.Response.StatusCode())
assert.NotEmpty(t, <-messageQueue)
}

Expand Down Expand Up @@ -391,7 +391,7 @@ func TestHandle_Success_PushEvent_FlatUser(t *testing.T) {

handler.Handle(ctx)

assert.Equal(t, fasthttp.StatusAccepted, ctx.Response.StatusCode())
assert.Equal(t, fasthttp.StatusOK, ctx.Response.StatusCode())
msg := <-messageQueue
assert.NotNil(t, msg)
assert.Equal(t, string(msg.Value.(sarama.ByteEncoder)), body)
Expand Down Expand Up @@ -428,7 +428,7 @@ func TestHandle_Success_UserAddToGroup(t *testing.T) {

handler.Handle(ctx)

assert.Equal(t, fasthttp.StatusAccepted, ctx.Response.StatusCode())
assert.Equal(t, fasthttp.StatusOK, ctx.Response.StatusCode())
assert.NotEmpty(t, <-messageQueue)
}

Expand Down Expand Up @@ -461,7 +461,7 @@ func TestHandle_Success_SubgroupCreate(t *testing.T) {

handler.Handle(ctx)

assert.Equal(t, fasthttp.StatusAccepted, ctx.Response.StatusCode())
assert.Equal(t, fasthttp.StatusOK, ctx.Response.StatusCode())
assert.NotEmpty(t, <-messageQueue)
}

Expand Down Expand Up @@ -497,5 +497,5 @@ func TestMessageQueue_Full(t *testing.T) {
// Wait a bit for goroutine to execute default case (queue full)
time.Sleep(50 * time.Millisecond)

assert.Equal(t, fasthttp.StatusAccepted, ctx.Response.StatusCode())
assert.Equal(t, fasthttp.StatusOK, ctx.Response.StatusCode())
}