Skip to content

fix: use platform path separator in attachment validation #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmbutko wants to merge 1 commit into from
+3 −3
Closed

fix: use platform path separator in attachment validation #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/server/ws/attachment-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('isValidAttachmentPath', () => {

it('rejects paths that match the prefix as a substring but are not inside it', () => {
// e.g. /tmp/copilot-uploads-evil/file.txt should not match /tmp/copilot-uploads/
expect(isValidAttachmentPath(UPLOAD_PREFIX + '-evil/file.txt')).toBe(false);
expect(isValidAttachmentPath(join(UPLOAD_PREFIX + '-evil', 'file.txt'))).toBe(false);
});
});

Expand Down
4 changes: 2 additions & 2 deletions src/lib/server/ws/attachments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { resolve } from 'node:path';
import { resolve, sep } from 'node:path';
import { logSecurity } from '../security-log.js';
import { UPLOAD_DIR_PREFIX } from './constants.js';

Expand All @@ -12,7 +12,7 @@ export type SdkAttachment =
/** Validate that an attachment path is an absolute path inside the upload directory (prevents arbitrary file reads). */
export function isValidAttachmentPath(filePath: string): boolean {
const resolved = resolve(filePath);
return resolved.startsWith(UPLOAD_DIR_PREFIX + '/');
return resolved.startsWith(UPLOAD_DIR_PREFIX + sep);
}

/** Map client-sent attachments to the SDK format, validating paths and filtering invalid entries. */
Expand Down
Loading