security(stream): document exact-deposit transfer, add approval audit test#3
Open
devUnixx wants to merge 1 commit into
Open
security(stream): document exact-deposit transfer, add approval audit test#3devUnixx wants to merge 1 commit into
devUnixx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Vera3289#65
Changes
Contract comment (
contracts/stream/src/lib.rs)Added a
# Token approval / transfer security (#65)doc-comment tocreate_streamexplaining:token::transfer(employer → contract, deposit)— exactlydeposit, nothing moreapprovecall is issued by the contract itselfdeposittokens; the contract cannot pull more than that single authorisationTest (
contracts/stream/src/test.rs)Added
test_create_stream_transfers_exact_deposit:create_streamwith a known deposit amountdepositdepositSecurity posture
The approval model is already minimal (exact-deposit, no unlimited approval). This PR makes that guarantee explicit and machine-verified.