Issue/20 e2e movement fix#21
Merged
Merged
Conversation
Adds Playwright e2e coverage for all piece types and the multi-move flow, and fixes a server-side bug where MakeMove rejected UCI strings for piece moves (d1e2, e1g1, etc.) by trying to parse them as SAN. The client builds move strings by concatenating source + destination squares (UCI) and the server's validMoves encoder already returns UCI, but MakeMove's decoder was AlgebraicNotation. SAN rejects 'd1e2' because it expects a piece letter prefix. Switching MakeMove and GetBotMove to UCINotation keeps the wire format consistent. Also improves the bot: PSTs, mobility term, and random tie-break so it plays non-knight opening moves (issue dev-rkb#4 follow-up). Closes dev-rkb#20
Contributors were attempting 'git push dev-rkb' which fails with authentication errors. The dev-rkb remote is the contributor's personal fork and requires separate credentials. Use 'git push origin' instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.