Conversation
Addresses compiler-specific issues preventing the build from completing on macOS. Currently builds, but fails to create OpenGL context due to OS-specific issue
Owner
|
Has been mentioned in DMs, but I'll mention it here if anyone wants to add onto this or look into it: Apple seems to support legacy profile opengl only. The shaders may or may not use some features that are only present in newer versions. The fix is to ifdef static initialization of Object shaders, that are present in the Renderer/Object.cpp file, and have custom shaders for macos. In addition to this, the imgui impl has to be changed. |
Still having additional issues creating a GLFW context on Catalina and Big Sur machines, although this may be an issue with my KVM and graphics acceleration. Regardless, any OpenGL contexts on these platforms will be limited to software mode.
This reverts commit bfa36111e9d5e9672e84380a942d371bf69e64e8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial, incomplete support for building on macOS. Project builds but fails to open due to an OpenGL context issue. Will be addressed