S7+F1+F6+S6+B4: password reset + health endpoint + CSRF + entry-point unification#340
Merged
Conversation
S7: resetPassword() returns success message, no plaintext password Stores Argon2ID-hashed token with 15-min expiry; sets must_change_password=1 login/refresh throw PasswordChangeRequiredException when flag set New migrations: logout_all_devices_at, password_reset_fields New: RequestAuthenticator (shared cookie+bearer auth + CSRF check) S6+B4+C3+C6: CSRF protection for cookie-auth + unified entry-point RequestAuthenticator handles cookie+bearer auth; validates Origin/Referer for cookie-auth POST/PUT/DELETE/PATCH; used by both HttpHandler and public/index.php Docstrings corrected on AuthMiddleware and AdminMiddleware F6: health endpoint /admin/health/jobs Reports transcode/scan job counts + oldest age + last reaper run time Builds on P3+B1 reaper infrastructure
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Compatibility | 1 medium 4 high |
| BestPractice | 7 medium |
| Documentation | 2 minor |
| ErrorProne | 12 medium |
| Security | 1 high |
| CodeStyle | 15 minor |
| Complexity | 4 medium |
🟢 Metrics 61 complexity · 0 duplication
Metric Results Complexity 61 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S7+F1 — Password reset: stop plaintext, force-change + expiry
resetPassword()now returns success message (no plaintext password)must_change_password=1flaglogin()/refreshToken()throwPasswordChangeRequiredExceptionwhen flag setF6 — Health endpoint /admin/health/jobs
S6+B4+C3+C6 — CSRF protection for cookie-auth + unified entry-point
RequestAuthenticatorclass — shared cookie+bearer auth + Origin/Referer validationHttpHandlerandpublic/index.php(same auth behavior)Verification
./vendor/bin/phpstan analyze --level=9— no errors ✅./vendor/bin/phpcs PSR-12— no errors ✅